fix: disable facets knowledge panels for crawlers #8772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product history
Codecov Report
@@ Coverage Diff @@
## main #8772 +/- ##
===========================================
- Coverage 48.72% 31.50% -17.23%
===========================================
Files 117 64 -53
Lines 21911 17653 -4258
Branches 4871 4058 -813
===========================================
- Hits 10677 5562 -5115
- Misses 9930 11273 +1343
+ Partials 1304 818 -486
... and 82 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to openfoodfacts/facets-knowledge-panels#123 : we don't want to load facets knowledge panels for crawlers.
In the future, we might want to disable other things for crawlers, this PR makes is_crawl_bot available to the template engine (only for tags right now, it should be added for all templates later)